freyja 1.4.3 with update #656
Conversation
|
Freyja Version 1.4.3 came out a few days ago, so I've added that Dockerfile to this PR. This Dockerfile contains the I don't think we need to include 1.4.2-update in the Dockerhub or Quay repo, but I built it... and it works fine... so it's been left in. For Cecret, I've been creating my own weekly Freyja containers to keep the variants in the container up-to-date (ish). It can be found here : https://quay.io/repository/uphl/freyja?tab=tags |
|
Dockerfiles look good to me, tests run as expected. I pushed a small commit that adds a relative link in I'm going to merge this PR and deploy the image for v1.4.3 and overwrite the If you'd like to add a GH actions workflow for deploying new images every 2 weeks, I would recommend doing so in a separate pull request. In the meantime, you could trigger the "manual deploy" workflow that we typically use, and just update the docker image tag with the date of deployment, e.g. |
|
I'll let you delete the dev branch if you are finished with it Deploy workflow here: https://github.com/StaPH-B/docker-builds/actions/runs/5195018104 docker image should be available shortly |
This is the plan that I came up with to address
freyja updatenot being a viable option in the container (see #655).The plan:
I took the dockerfile for 1.4.2
I propose, we push this image to dockerhub and quay every week or so with github actions using the tag 1.4.2-yyyy-mm-dd of the date that we are pushing to dockerhub and quay, and overwrite the latest tag. That way, we don't have to re-write the dockerfile every time we want to update freyja's variants.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15)spades/3.12.0/Dockerfile)shigatyper/2.0.1/test.sh)spades/3.12.0/README.md)